View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001641 | Chrono Download Manager | Bug | public | 2016-07-09 09:30 | 2018-07-11 22:05 |
| Reporter | DCoder | Assigned To | admin | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Platform | Desktop | OS | Windows | OS Version | 10 |
| Target Version | 0.10.0 | Fixed in Version | 0.10.0 | ||
| Summary | 0001641: Second download prompt for the same file | ||||
| Description | I normally have the Chrono manager open in a pinned tab. After right-clicking a link in a regular tab and choosing "Download the link...", the Chrono dialog shows up as expected. But when I close that regular tab, the Chrono tab throws up another download dialog for that file. | ||||
| Additional Information | This started sometime around the time Chrome 48 was released. I looked through the extension code and tracked this issue down to a breakdown in communication: * the menu action sends a message to Chrono to add a new download, and expects a response. * The message receiver code does not send a response, so Chrome invokes the response callback when cleaning up during tab close. (This behaviour is documented by Chrome, https://developer.chrome.com/extensions/messaging#simple says: "The sendMessage function's callback will be invoked automatically if no handlers return true or if the sendResponse callback is garbage-collected.") * The response callback sees that it did not get a response, so it panics, logs a message to the console: "menu download no response", and tells Chrono to open the new task dialog again. If this project had a repository with the original source code available, I could try and make a pull request to fix this. | ||||
| Tags | No tags attached. | ||||
| Chrome Version | 51.0.2704.103m | ||||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2016-07-09 09:30 | DCoder | New Issue | |
| 2017-05-25 18:45 | admin | Target Version | => 0.10.0 |
| 2018-07-11 21:59 | admin | Fixed in Version | => 0.10.0 |
| 2018-07-11 22:01 | admin | Status | new => resolved |
| 2018-07-11 22:02 | admin | Status | resolved => closed |
| 2018-07-11 22:05 | admin | Status | closed => new |
| 2018-07-11 22:05 | admin | Status | new => resolved |
| 2018-07-11 22:05 | admin | Resolution | open => fixed |
| 2018-07-11 22:05 | admin | Assigned To | => admin |
